feat: adopt new context menu in query builder
Special point of attention for review: this removes the filter from the attribute list, and instead uses floating-ui typeahead. This means you can type when the submenu is opened, and it will select it. Pressing enter selects the item. You can also navigate with arrows. HOWEVER, this is a bit more hidden than the previous filter implementation. I personally prefer this, but we may have to teach customers that this exists if they need it (Marijn?).
Merge request reports
Activity
added 10 commits
- d77ca0bb - chore: remove debug line
- 18d6538f - feat: update querybuilder to use new menu component
- 91984e58 - feat: maximum height and scrollbars on context menu
- 1112c330 - refactor: remove unused code, filtering is done by typing in the menu
- a0963a01 - feat: re-add attribute type icons
- 517b358d - refactor: small fixes
- b7ba1b0c - fix: hidden menu trigger
- 5e9c407e - style: apply autoformatter
- 55d6174a - refactor: graph counts after rebase
- fd67e88f - fix: rebase issues
Toggle commit listadded 10 commits
-
20002f14 - 1 commit from branch
main - 5489bf48 - feat: update querybuilder to use new menu component
- eb30b745 - feat: maximum height and scrollbars on context menu
- ce833575 - refactor: remove unused code, filtering is done by typing in the menu
- d304fc5f - feat: re-add attribute type icons
- 009bba2d - refactor: small fixes
- 99a441b7 - fix: hidden menu trigger
- c3e5501a - style: apply autoformatter
- 160f8fdd - refactor: graph counts after rebase
- e37a90f6 - fix: rebase issues
Toggle commit list-
20002f14 - 1 commit from branch
added 10 commits
-
d0c8cd93 - 1 commit from branch
main - 700ebb37 - feat: update querybuilder to use new menu component
- 9fef168c - feat: maximum height and scrollbars on context menu
- 6c480eac - refactor: remove unused code, filtering is done by typing in the menu
- a9d848fc - feat: re-add attribute type icons
- 4d3822db - refactor: small fixes
- 951c0dab - fix: hidden menu trigger
- b80ffff5 - style: apply autoformatter
- 007f0de1 - refactor: graph counts after rebase
- 82cc1b11 - fix: rebase issues
Toggle commit list-
d0c8cd93 - 1 commit from branch
added 11 commits
-
82cc1b11...16f3a17e - 2 commits from branch
main - e48b5537 - feat: update querybuilder to use new menu component
- bcff5f42 - feat: maximum height and scrollbars on context menu
- 39a41d68 - refactor: remove unused code, filtering is done by typing in the menu
- d7a5674e - feat: re-add attribute type icons
- f2981d78 - refactor: small fixes
- 052ce8ad - fix: hidden menu trigger
- 2dbd9b5b - style: apply autoformatter
- be4544e0 - refactor: graph counts after rebase
- 0fdc8233 - fix: rebase issues
Toggle commit list-
82cc1b11...16f3a17e - 2 commits from branch
Some comments to consider:
- Checkboxes are different from GP ones.
- When I check an attribute, submenu (the one with attributes) still there.
- With long attributes it becomes huge (from the insurance DB ...)
- Related to previous one, I would put the icons between the checkbox and the string, otherwise they are far away.
- Difficult to manage search. With the previous input filter I could know what I typed. Also matching substrings are not highlighted (that's typehead functionality, no ?)
- Filter also have same context menus as nodes and relationships pills
Offtopic/related: should sort alphabetically always all attributes lists ? So users expect in which position find elements?
Checkboxes are different from GP ones.
Yep I trust Duncan for this one. Generally checkboxes are square and radio buttons round, so I think changing the GP checkboxes might be better than updating these. I think Duncan has a plan for this
With long attributes it becomes huge (from the insurance DB ...)
Eh yes, but it scrolls right? I added a max height and custom scrollbars for this. Is this a problem for you still?
added 12 commits
-
d1218a4a - 1 commit from branch
main - c49758df - 1 earlier commit
- 8d4d7cee - feat: maximum height and scrollbars on context menu
- 67b649e5 - refactor: remove unused code, filtering is done by typing in the menu
- c5dc174d - feat: re-add attribute type icons
- c3ace4f0 - refactor: small fixes
- 2d30926f - fix: hidden menu trigger
- b254ead4 - style: apply autoformatter
- 2268d759 - refactor: graph counts after rebase
- baa882e5 - fix: rebase issues
- ad52317f - feat: close context menu on click
- da4b5fda - fix: scroll bar dark mode
Toggle commit list-
d1218a4a - 1 commit from branch
enabled an automatic merge when all merge checks for da4b5fda pass
The release is available on GitLab release.
Your semantic-release bot
