Skip to content
Snippets Groups Projects

feat: client updater bun rework

Merged Leonardo Christino requested to merge feat/clientBun into main
2 unresolved threads
Files
18
+ 4
4
@@ -38,13 +38,13 @@ export function App(props: App) {
const dispatch = useAppDispatch();
const [monitoringOpen, setMonitoringOpen] = useState<boolean>(false);
const runQuery = () => {
const rerunQuery = () => {
if (session?.currentSaveState && query) {
if (query.nodes.length === 0) {
dispatch(resetGraphQueryResults());
} else {
dispatch(queryingBackend());
wsQueryRequest(ml);
wsQueryRequest(session.currentSaveState, ml);
    • In a recent change to the clientupdater, I obtained the savestate from the headers instead of passing it as a request parameter. It is a bit confusing and unecessary to send the savestate both in the headers, and in the message body. See graphpolaris/microservices/client-updater-service!13 (merged).

      Is it really required to reintroduce the savestateID here? Note, since I expect this to happen in multiple places, we can tackle this in a separate PR, consistent over all request. But would like to know a bit of context first

Please register or sign in to reply
}
}
};
@@ -66,7 +66,7 @@ export function App(props: App) {
return (
<div className="h-screen w-screen overflow-clip">
<EventBus
onRunQuery={runQuery}
onRunQuery={rerunQuery}
onAuthorized={() => {
setAuthCheck(true);
}}
@@ -129,7 +129,7 @@ export function App(props: App) {
fallback={<div>Something went wrong</div>}
onError={() => dispatch(addError('Something went wrong while trying to load the query builder'))}
>
<QueryBuilder onRunQuery={runQuery} />
<QueryBuilder onRunQuery={rerunQuery} />
</ErrorBoundary>
</Resizable>
</Resizable>
Loading