Skip to content
Snippets Groups Projects

fix: update shape dropdown to correctly handle node shape selection

Merged Marcos Pieras requested to merge fix/nodeLinkSettignsError into main
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
218 217 <Input
219 218 type="dropdown"
220 219 label="Shape"
221 value={settings.shapes.shape}
222 options={[{ circle: 'Circle' }, { rectangle: 'Square' }]}
  • I changed this part back, because it shows more user-friendly 'Circle' and 'Square' labels instead of the internally used 'circle' and 'rectangle'. This wasn't necessary for the fix.

  • Please register or sign in to reply
  • Great catch, seems like I missed this part in the rebase, it incorrectly reverted to using the old settings format settings.shapes.shape. Made a small correction, otherwise good to merge! :)

  • Dennis Collaris approved this merge request

    approved this merge request

  • Dennis Collaris added 2 commits

    added 2 commits

    • c1597ca1 - 1 commit from branch main
    • ae1b0ffa - fix: update shape dropdown to correctly handle node shape selection

    Compare with previous version

  • Dennis Collaris enabled an automatic merge when the pipeline for ae1b0ffa succeeds

    enabled an automatic merge when the pipeline for ae1b0ffa succeeds

  • Dennis Collaris canceled the automatic merge

    canceled the automatic merge

  • :tada: This MR is included in version 1.89.2 :tada:

    The release is available on GitLab release.

    Your semantic-release bot :package: :rocket:

  • Please register or sign in to reply
    Loading