feat: Sentry frontend error logging integration
- Added error boundaries to the entire system
- Implemented Sentry error tracking
Merge request reports
Activity
requested review from @decode
assigned to @s.a.vink
added 7 commits
-
6a70f6ac - 1 commit from branch
main
- e37db43e - feat(errorBoundary): added error boundary
- 5fcd071a - feat(errorBoundary): added boundaries
- 90e56aad - feat(errorBoundary): added vis boundary
- a70a7f71 - feat(errorBoundary): extended description
- 078aa731 - feat(errorBoundary): updated location
- 18c3deaa - feat(errorBoundary): sentry for error logging
Toggle commit list-
6a70f6ac - 1 commit from branch
Nice, quickly done :). I am not 100% sure about the use of a special
ErrorBoundary
component for this, is this how sentry suggest using it? In my opinion the template is only for representational logic or elements: what is shown to the user. This adds quite a bit of additional complexity to the template, but does not really show in the apply flow.I think I would prefer just injecting sentry early on in
createRoot
inmain.tsx
, like described here: https://docs.sentry.io/platforms/javascript/guides/react/#react-19-error-reporting. What do you think, worth investigating?
added 13 commits
-
94f64b71...702ec3d8 - 6 commits from branch
main
- abb20410 - feat(errorBoundary): added error boundary
- 55712aef - feat(errorBoundary): added boundaries
- 0d788d8f - feat(errorBoundary): added vis boundary
- d37bd98c - feat(errorBoundary): extended description
- 0526817d - feat(errorBoundary): updated location
- 2ccc237a - feat(errorBoundary): sentry for error logging
- 1a81d85d - feat(errorBoundary): removed error boundary
Toggle commit list-
94f64b71...702ec3d8 - 6 commits from branch
Ah ok it was just a matter of removing them, neat :) Lets see how this works without the error boundaries. We can always cherry pick the changes from this PR if we want to introduce error boundaries later.
I am trying out the PR, but for me
Sentry.init
is never called. I believe it is required to also update.env.example
, otherwise the env variable does not show up. @s.a.vink can you add this?For future reference or anyone else reading about this change: you need to run
pnpm build-env
to clear the env variable cache, otherwise sentry is never started! Also needs to happen on the staging environment.
added 8 commits
- c716d5a6 - feat(errorBoundary): added error boundary
- c3455d12 - feat(errorBoundary): added boundaries
- 4a929eea - feat(errorBoundary): added vis boundary
- 2dfe18cf - feat(errorBoundary): extended description
- 5380a037 - feat(errorBoundary): updated location
- 12449e6d - feat(errorBoundary): sentry for error logging
- a0451521 - feat(errorBoundary): removed error boundary
- 7333a94e - feat(errorBoundary): removed error boundary
Toggle commit listadded 17 commits
-
7333a94e...a4466c8d - 2 commits from branch
main
- a4466c8d...acea7fd1 - 5 earlier commits
- b082eb49 - feat(errorBoundary): sentry for error logging
- 3a2a0ee4 - feat(errorBoundary): removed error boundary
- 9cf0c449 - feat(errorBoundary): added error boundary
- 7ef27cde - feat(errorBoundary): added boundaries
- 2516cc04 - feat(errorBoundary): added vis boundary
- 8fa09632 - feat(errorBoundary): extended description
- 2b516669 - feat(errorBoundary): updated location
- 0a3ef651 - feat(errorBoundary): sentry for error logging
- 5d93d973 - feat(errorBoundary): removed error boundary
- 63fa4d43 - fix(errorBoundary): add missing examples env file
Toggle commit list-
7333a94e...a4466c8d - 2 commits from branch
LGTM! I approved the PR, but will merge a bit later (tomorrow?) to ensure I have time to fix staging issues with .env if they emerge.
Edited by Dennis Collaris This MR is included in version 1.82.0The release is available on GitLab release.
Your semantic-release bot