feat(mlResults): added indication for ML results to QB

requested review from @decode

assigned to @s.a.vink

added 4 commits

• 24d3d6e7...b35d69b5 - 3 commits from branch main
• 96e2d1b4 - feat(mlResults): added indication for ML results to QB

Compare with previous version

Hmm interesting idea. It is certainly more consistent with the way the limit control works. However, Im not sure people will discover they have to hover the ML button to see what the result is. Perhaps its better to keep the result descriptions in the QueryMLDialog, along with these changes, what do you think?

Along with these, I think we should use a different border color than "danger". As the name implies, it indicates something is wrong. Perhaps a blue outline?

added 1 commit

• b7eb52a6 - feat(mlResults): changed active color and put back ml info

Compare with previous version

added 16 commits

• b7eb52a6...c019d96c - 14 commits from branch main
• b3d61fe3 - feat(mlResults): added indication for ML results to QB
• fd4ebdc3 - feat(mlResults): changed active color and put back ml info

Compare with previous version

requested review from @marcos and removed review request for @decode

Good to merge.

small comment: could you fix the fonts of the results on ML popover ? results typography is larger than the chechbox one.

Side comments (future work):

• ML options shouldnot be mutually exclusive ? at least results they are
• show color legend of results on inspector panel ?

merged

🎉 This MR is included in version 1.83.0 🎉

The release is available on GitLab release.

Your semantic-release bot 📦 🚀