feat(qb): simple count
Merge request reports
Activity
assigned to @milho001
added 1 commit
- 859422c8 - fix: include metattributes when attributes not set
1 import { SchemaAttribute } from '../../..'; 2 import { Handles, QueryElementTypes } from '../reactflow'; 3 import { QueryGraphEdgeAttribute, QueryGraphEdgeHandle, QueryGraphNodes } from './model'; 4 5 const metaAttribute: Record<string, QueryGraphEdgeAttribute> = { 6 '(# conn)': { -
This is user-facing information, perhaps its a bit more friendly to not abbreviate, I think there is the space for it? e.g. "# of connections" or even "number of connections". Would it be possible to contextualize the attribute, e.g., "# of Movie connections"? This would make it much clearer.
Also: why the choice to put this one between brackets, to indicate it is a meta attribute? Perhaps it would be cleaner to have a separate icon for it (not in this PR tho, new asana task) :)
changed this line in version 4 of the diff
-
We identified an issue with meta attributes not showing up, this was addressed in e878e3ff.
As far as I can judge (not fully familiar with the codebase) I think it looks good. Nice to make attributes non-optional, its an array that can be empty so null does not make a lot of sense to me.
LGTM! :)
The release is available on GitLab release.
Your semantic-release bot
