refactor: memoize children ref to prevent recreating virtual elements every update

a07fe8ef · Dennis Collaris · 9c40e341 · a07fe8ef
Commit a07fe8ef authored 9 months ago by Dennis Collaris
--- a/libs/shared/lib/components/tooltip/Tooltip.tsx
+++ b/libs/shared/lib/components/tooltip/Tooltip.tsx
@@ -106,14 +106,13 @@ export const TooltipTrigger = React.forwardRef<HTMLElement, React.HTMLProps<HTML
  propRef,
 ) {
  const context = useTooltipContext();
-  let childrenRef;
-
-  if (children == null) {
-    const element = React.createElement('div');
-    childrenRef = element.ref;
-  } else {
-    childrenRef = (children as React.ReactElement).ref;
-  }
+  const childrenRef = React.useMemo(() => {
+    if (children == null) {
+      return React.createElement('div').ref;
+    } else {
+      return (children as React.ReactElement).ref;
+    }
+  }, [children]);

  const ref = useMergeRefs([context.data.refs.setReference, propRef, childrenRef]);