From d7bf30de3fd136641df7193943d61d2991de9a6b Mon Sep 17 00:00:00 2001
From: Dennis Collaris <d.collaris@me.com>
Date: Mon, 9 Dec 2024 15:56:35 +0100
Subject: [PATCH 1/2] fix: typo
---
libs/shared/lib/insight-sharing/FormReport.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libs/shared/lib/insight-sharing/FormReport.tsx b/libs/shared/lib/insight-sharing/FormReport.tsx
index e41546b2f..69e7a95bd 100644
--- a/libs/shared/lib/insight-sharing/FormReport.tsx
+++ b/libs/shared/lib/insight-sharing/FormReport.tsx
@@ -192,7 +192,7 @@ export function FormReport(props: Props) {
editorState={editorState}
setEditorState={setEditorState}
showToolbar={true}
- placeholder="Start typing your alert template..."
+ placeholder="Start typing your report template..."
handleSave={handleSave}
><Button label="Delete" variantType="secondary" variant="outline" onClick={handleDelete} /></TextEditor>
</AccordionBody>
--
GitLab
From 837e9c440cfd5024140e56671eb43b70b81efb89 Mon Sep 17 00:00:00 2001
From: Dennis Collaris <d.collaris@me.com>
Date: Mon, 9 Dec 2024 16:10:34 +0100
Subject: [PATCH 2/2] fix: fallback value if insights do not exist yet
---
libs/shared/lib/data-access/store/insightSharingSlice.ts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libs/shared/lib/data-access/store/insightSharingSlice.ts b/libs/shared/lib/data-access/store/insightSharingSlice.ts
index a3a4105e0..ed0bd66ec 100644
--- a/libs/shared/lib/data-access/store/insightSharingSlice.ts
+++ b/libs/shared/lib/data-access/store/insightSharingSlice.ts
@@ -67,8 +67,8 @@ const insightSharingSlice = createSlice({
export const { setInsights, addInsight, updateInsight, deleteInsight } = insightSharingSlice.actions;
-export const selectReports = (state: RootState): InsightResponse[] => state.insightSharing.insights.filter((i) => i.type === 'report');
-export const selectAlerts = (state: RootState): InsightResponse[] => state.insightSharing.insights.filter((i) => i.type === 'alert');
-export const selectInsights = (state: RootState): InsightResponse[] => state.insightSharing.insights;
+export const selectReports = (state: RootState): InsightResponse[] => state.insightSharing?.insights?.filter((i) => i.type === 'report') ?? [];
+export const selectAlerts = (state: RootState): InsightResponse[] => state.insightSharing?.insights?.filter((i) => i.type === 'alert') ?? [];
+export const selectInsights = (state: RootState): InsightResponse[] => state.insightSharing?.insights ?? [];
export default insightSharingSlice.reducer;
--
GitLab