From d0c8cd935e72ebd7d15306256b82a19eec084d8a Mon Sep 17 00:00:00 2001
From: Dennis Collaris <d.collaris@me.com>
Date: Fri, 28 Mar 2025 17:27:06 +0100
Subject: [PATCH] fix(context-menu): prevent right click behavior from blocking
onclick
---
src/lib/components/menu/index.tsx | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/lib/components/menu/index.tsx b/src/lib/components/menu/index.tsx
index c2385f924..060c950e7 100644
--- a/src/lib/components/menu/index.tsx
+++ b/src/lib/components/menu/index.tsx
@@ -246,11 +246,14 @@ export const MenuTrigger = React.forwardRef<HTMLElement, MenuTriggerProps>(
};
delete referenceProps.onMouseDown;
delete referenceProps.onPointerDown;
- referenceProps.onClick = (event: React.MouseEvent) => {
- event.preventDefault();
- console.log('Click event!!!', context.isOpen);
- context.setIsOpen(false);
- };
+ delete referenceProps.onClick;
+
+ if (context.isOpen) {
+ referenceProps.onClick = (event: React.MouseEvent) => {
+ event.preventDefault();
+ context.setIsOpen(false);
+ };
+ }
}
const element = React.cloneElement(children as React.ReactElement<{ ref?: React.Ref<HTMLElement> }>, {
--
GitLab