From 93c5dcb4f8606920ea8fb79d54a2e105a97e9522 Mon Sep 17 00:00:00 2001
From: Leonardo <leomilho@gmail.com>
Date: Mon, 23 Sep 2024 16:50:25 +0200
Subject: [PATCH] fix: nl layout update on setting change
---
libs/shared/lib/graph-layout/graphology-layouts.ts | 4 ++--
.../lib/vis/visualizations/nodelinkvis/components/NLPixi.tsx | 2 +-
.../shared/lib/vis/visualizations/nodelinkvis/nodelinkvis.tsx | 2 --
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/libs/shared/lib/graph-layout/graphology-layouts.ts b/libs/shared/lib/graph-layout/graphology-layouts.ts
index 0f197a791..9562320e1 100644
--- a/libs/shared/lib/graph-layout/graphology-layouts.ts
+++ b/libs/shared/lib/graph-layout/graphology-layouts.ts
@@ -88,7 +88,7 @@ export class GraphologyCircular extends GraphologyLayout {
super.layout(graph, boundingBox);
// To directly assign the positions to the nodes:
circular.assign(graph, {
- scale: graph.order * graph.order,
+ scale: (graph.order * graph.order) / 10,
...this.defaultLayoutSettings,
});
}
@@ -111,7 +111,7 @@ export class GraphologyRandom extends GraphologyLayout {
// To directly assign the positions to the nodes:
random.assign(graph, {
- scale: graph.order * graph.order,
+ scale: (graph.order * graph.order) / 10,
...this.defaultLayoutSettings,
center: 0,
});
diff --git a/libs/shared/lib/vis/visualizations/nodelinkvis/components/NLPixi.tsx b/libs/shared/lib/vis/visualizations/nodelinkvis/components/NLPixi.tsx
index 947f02d9c..8ebba0b35 100644
--- a/libs/shared/lib/vis/visualizations/nodelinkvis/components/NLPixi.tsx
+++ b/libs/shared/lib/vis/visualizations/nodelinkvis/components/NLPixi.tsx
@@ -932,7 +932,7 @@ export const NLPixi = forwardRef((props: Props, refExternal) => {
// force.simulation.on('tick', () => {});
app.ticker.add(tick);
layoutState.current = 'reset';
- if (forceClear) setupLayout(forceClear);
+ if (forceClear || layoutAlgorithm.current.algorithm !== config.LAYOUT_ALGORITHM) setupLayout(forceClear);
}
};
diff --git a/libs/shared/lib/vis/visualizations/nodelinkvis/nodelinkvis.tsx b/libs/shared/lib/vis/visualizations/nodelinkvis/nodelinkvis.tsx
index 3eb918fff..a62b3e883 100644
--- a/libs/shared/lib/vis/visualizations/nodelinkvis/nodelinkvis.tsx
+++ b/libs/shared/lib/vis/visualizations/nodelinkvis/nodelinkvis.tsx
@@ -176,8 +176,6 @@ const NodelinkSettings = ({ settings, graphMetadata, updateSettings }: Visualiza
if (!settings.nodeList) return null;
- settings = patchLegacySettings(settings);
-
return (
<SettingsContainer>
<div className="mb-4 text-xs">
--
GitLab