From 7f19178df22c6c2ba184df1a62cb8df64f38a045 Mon Sep 17 00:00:00 2001
From: Michael Behrisch <m.behrisch@uu.nl>
Date: Sun, 6 Feb 2022 21:21:06 +0100
Subject: [PATCH] refactor: :art: renames graphpolaris-e2e to
web-graphpolaris-e2e
To follow the convention outlined in https://medium.com/showpad-engineering/how-to-organize-and-name-applications-and-libraries-in-an-nx-monorepo-for-immediate-team-wide-9876510dbe28 we need to update the app names and prefix with the intended deployment environment (web, windows, react-native)
---
apps/graphpolaris-e2e/src/integration/app/app.spec.ts | 7 -------
.../.eslintrc.json | 2 +-
.../cypress.json | 4 ++--
.../project.json | 8 ++++----
.../src/fixtures/example.json | 0
.../src/integration/app.spec.ts | 0
apps/web-graphpolaris-e2e/src/integration/app/app.spec.ts | 7 +++++++
.../src/support/app.po.ts | 0
.../src/support/commands.ts | 0
.../src/support/index.ts | 0
.../tsconfig.json | 0
workspace.json | 4 ++--
12 files changed, 16 insertions(+), 16 deletions(-)
delete mode 100644 apps/graphpolaris-e2e/src/integration/app/app.spec.ts
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/.eslintrc.json (80%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/cypress.json (62%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/project.json (69%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/src/fixtures/example.json (100%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/src/integration/app.spec.ts (100%)
create mode 100644 apps/web-graphpolaris-e2e/src/integration/app/app.spec.ts
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/src/support/app.po.ts (100%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/src/support/commands.ts (100%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/src/support/index.ts (100%)
rename apps/{graphpolaris-e2e => web-graphpolaris-e2e}/tsconfig.json (100%)
diff --git a/apps/graphpolaris-e2e/src/integration/app/app.spec.ts b/apps/graphpolaris-e2e/src/integration/app/app.spec.ts
deleted file mode 100644
index 161316b77..000000000
--- a/apps/graphpolaris-e2e/src/integration/app/app.spec.ts
+++ /dev/null
@@ -1,7 +0,0 @@
-describe('graphpolaris: App component', () => {
- beforeEach(() => cy.visit('/iframe.html?id=app--primary'));
-
- it('should render the component', () => {
- cy.get('h1').should('contain', 'Welcome to App!');
- });
-});
diff --git a/apps/graphpolaris-e2e/.eslintrc.json b/apps/web-graphpolaris-e2e/.eslintrc.json
similarity index 80%
rename from apps/graphpolaris-e2e/.eslintrc.json
rename to apps/web-graphpolaris-e2e/.eslintrc.json
index 4c5989b23..8481bd307 100644
--- a/apps/graphpolaris-e2e/.eslintrc.json
+++ b/apps/web-graphpolaris-e2e/.eslintrc.json
@@ -1,5 +1,5 @@
{
- "extends": ["plugin:cypress/recommended", "../../.eslintrc.json"],
+ "extends": ["plugin:cypress/recommended", "..\\..\\.eslintrc.json"],
"ignorePatterns": ["!**/*"],
"overrides": [
{
diff --git a/apps/graphpolaris-e2e/cypress.json b/apps/web-graphpolaris-e2e/cypress.json
similarity index 62%
rename from apps/graphpolaris-e2e/cypress.json
rename to apps/web-graphpolaris-e2e/cypress.json
index 9ad16ab4d..bf3f402a2 100644
--- a/apps/graphpolaris-e2e/cypress.json
+++ b/apps/web-graphpolaris-e2e/cypress.json
@@ -6,7 +6,7 @@
"supportFile": "./src/support/index.ts",
"pluginsFile": false,
"video": true,
- "videosFolder": "../../dist/cypress/apps/graphpolaris-e2e/videos",
- "screenshotsFolder": "../../dist/cypress/apps/graphpolaris-e2e/screenshots",
+ "videosFolder": "../../dist/cypress/apps/web-graphpolaris-e2e/videos",
+ "screenshotsFolder": "../../dist/cypress/apps/web-graphpolaris-e2e/screenshots",
"chromeWebSecurity": false
}
diff --git a/apps/graphpolaris-e2e/project.json b/apps/web-graphpolaris-e2e/project.json
similarity index 69%
rename from apps/graphpolaris-e2e/project.json
rename to apps/web-graphpolaris-e2e/project.json
index 9505a27eb..184963986 100644
--- a/apps/graphpolaris-e2e/project.json
+++ b/apps/web-graphpolaris-e2e/project.json
@@ -1,12 +1,12 @@
{
- "root": "apps/graphpolaris-e2e",
- "sourceRoot": "apps/graphpolaris-e2e/src",
+ "root": "apps/web-graphpolaris-e2e",
+ "sourceRoot": "apps/web-graphpolaris-e2e/src",
"projectType": "application",
"targets": {
"e2e": {
"executor": "@nrwl/cypress:cypress",
"options": {
- "cypressConfig": "apps/graphpolaris-e2e/cypress.json",
+ "cypressConfig": "apps/web-graphpolaris-e2e/cypress.json",
"devServerTarget": "web-graphpolaris:serve"
},
"configurations": {
@@ -19,7 +19,7 @@
"executor": "@nrwl/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
- "lintFilePatterns": ["apps/graphpolaris-e2e/**/*.{js,ts}"]
+ "lintFilePatterns": ["apps/web-graphpolaris-e2e/**/*.{js,ts}"]
}
}
},
diff --git a/apps/graphpolaris-e2e/src/fixtures/example.json b/apps/web-graphpolaris-e2e/src/fixtures/example.json
similarity index 100%
rename from apps/graphpolaris-e2e/src/fixtures/example.json
rename to apps/web-graphpolaris-e2e/src/fixtures/example.json
diff --git a/apps/graphpolaris-e2e/src/integration/app.spec.ts b/apps/web-graphpolaris-e2e/src/integration/app.spec.ts
similarity index 100%
rename from apps/graphpolaris-e2e/src/integration/app.spec.ts
rename to apps/web-graphpolaris-e2e/src/integration/app.spec.ts
diff --git a/apps/web-graphpolaris-e2e/src/integration/app/app.spec.ts b/apps/web-graphpolaris-e2e/src/integration/app/app.spec.ts
new file mode 100644
index 000000000..384084159
--- /dev/null
+++ b/apps/web-graphpolaris-e2e/src/integration/app/app.spec.ts
@@ -0,0 +1,7 @@
+describe('graphpolaris: App component', () => {
+ beforeEach(() => cy.visit('/iframe.html?id=app--primary'));
+
+ it('should render the component', () => {
+ cy.get('h1').should('contain', 'Welcome to App!');
+ });
+});
diff --git a/apps/graphpolaris-e2e/src/support/app.po.ts b/apps/web-graphpolaris-e2e/src/support/app.po.ts
similarity index 100%
rename from apps/graphpolaris-e2e/src/support/app.po.ts
rename to apps/web-graphpolaris-e2e/src/support/app.po.ts
diff --git a/apps/graphpolaris-e2e/src/support/commands.ts b/apps/web-graphpolaris-e2e/src/support/commands.ts
similarity index 100%
rename from apps/graphpolaris-e2e/src/support/commands.ts
rename to apps/web-graphpolaris-e2e/src/support/commands.ts
diff --git a/apps/graphpolaris-e2e/src/support/index.ts b/apps/web-graphpolaris-e2e/src/support/index.ts
similarity index 100%
rename from apps/graphpolaris-e2e/src/support/index.ts
rename to apps/web-graphpolaris-e2e/src/support/index.ts
diff --git a/apps/graphpolaris-e2e/tsconfig.json b/apps/web-graphpolaris-e2e/tsconfig.json
similarity index 100%
rename from apps/graphpolaris-e2e/tsconfig.json
rename to apps/web-graphpolaris-e2e/tsconfig.json
diff --git a/workspace.json b/workspace.json
index 85a7a2fcf..1a59e05a3 100644
--- a/workspace.json
+++ b/workspace.json
@@ -1,8 +1,8 @@
{
"version": 2,
"projects": {
- "graphpolaris-e2e": "apps/graphpolaris-e2e",
"shared-data-access-store": "libs/shared/data-access/store",
- "web-graphpolaris": "apps/web-graphpolaris"
+ "web-graphpolaris": "apps/web-graphpolaris",
+ "web-graphpolaris-e2e": "apps/web-graphpolaris-e2e"
}
}
--
GitLab